From 01ce71d61b6d0baddc2c8dcab1ab9804704e7c4d Mon Sep 17 00:00:00 2001 From: Pavel Kretov Date: Mon, 5 Mar 2018 02:26:25 +0300 Subject: [PATCH 1/2] Makefile.in: do not remove Makefile on 'make clean' This is the way how Autotools behaves, where is little reason to surprise newcomers with different behavior. Also, it may be really inconvenient to constantly rerun ./configure if one has to make a number of rebuilds which differ in CFLAGS only. Signed-off-by: Pavel Kretov --- Makefile.in | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Makefile.in b/Makefile.in index be993d6..0ceea5e 100755 --- a/Makefile.in +++ b/Makefile.in @@ -105,9 +105,10 @@ build/obj/ns_turn_msg.o: src/client/ns_turn_msg.c ${LUBCLIENTTURN_DEPS} ### Clean all: clean: - ${RMCMD} bin build lib obj *bak *~ */*~ */*/*~ */*/*/*~ *core */*core */*/*core include Makefile tmp sqlite + ${RMCMD} bin build lib obj *bak *~ */*~ */*/*~ */*/*/*~ *core */*core */*/*core include tmp sqlite distclean: clean + ${RMCMD} Makefile ### SQLite empty database: sqlite_empty_db : sqlite/turndb From 8617134e3957ed60e6cc8cdc97e4af51da64a10e Mon Sep 17 00:00:00 2001 From: Pavel Kretov Date: Mon, 5 Mar 2018 05:33:46 +0300 Subject: [PATCH 2/2] Makefile.in: list all phony targets as .PHONY Otherwise, these targets will fail to run if a developer incidentally created files named 'test' or 'sqlite_empty_db' in their working copy, which may be rather likely. Signed-off-by: Pavel Kretov --- Makefile.in | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Makefile.in b/Makefile.in index 0ceea5e..9e1dfbc 100755 --- a/Makefile.in +++ b/Makefile.in @@ -36,6 +36,8 @@ SERVERAPP_DEPS = ${SERVERTURN_MODS} ${SERVERTURN_DEPS} ${SERVERAPP_MODS} ${SERVE TURN_BUILD_RESULTS = bin/turnutils_oauth bin/turnutils_natdiscovery bin/turnutils_stunclient bin/turnutils_rfc5769check bin/turnutils_uclient bin/turnserver bin/turnutils_peer lib/libturnclient.a include/turn/ns_turn_defs.h sqlite_empty_db +.PHONY: all test check clean distclean sqlite_empty_db install deinstall uninstall reinstall + all: ${TURN_BUILD_RESULTS} test: check