master/coturn
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

reduce calls to random (#1710)

Browse Source 
implemented change suggested in TODO to speed up aes key generation
without, hopefully, negatively impacting the overall randomness of the
function

---------

Co-authored-by: Gustavo Garcia <gustavogb@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This commit is contained in:
redraincatching 2025-07-11 11:42:28 +01:00 committed by GitHub
parent 4de6c14f71
commit 68ac0772d9
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 15 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
src/apps/relay/mainrelay.c
View File

@ -37,6 +37,7 @@
#include "prom_server.h" #include "prom_server.h"
#include <assert.h> #include <assert.h>
#include <limits.h>
#if defined(WINDOWS) #if defined(WINDOWS)
#include <iphlpapi.h> #include <iphlpapi.h>
@ -1761,29 +1762,26 @@ void encrypt_aes_128(unsigned char *in, const unsigned char *mykey) {
printf("%s\n", base64_encoded); printf("%s\n", base64_encoded);
} }
static void generate_aes_128_key(char *filePath, unsigned char *returnedKey) { static void generate_aes_128_key(char *filePath, unsigned char *returnedKey) {
char key[16]; unsigned char key[16];
// TODO: Document why this is called...? // TODO: Document why this is called...?
turn_srandom(); turn_srandom();
// generate two 64-bit random values
#if LONG_MAX > 0xffffffff
uint64_t random_value_0 = (uint64_t)turn_random();
uint64_t random_value_1 = (uint64_t)turn_random();
#else
uint64_t random_value_0 = (((uint64_t)turn_random()) << 32) | (uint64_t)turn_random();
uint64_t random_value_1 = (((uint64_t)turn_random()) << 32) | (uint64_t)turn_random();
#endif
for (size_t i = 0; i < 16; ++i) { for (size_t i = 0; i < 16; ++i) {
// TODO: This could be sped up by breaking the // store the 128 random bits in the key array
// returned random value into multiple 8bit values key[i] = (i < 8) ? (random_value_0 >> (i * 8)) & 0xff : (random_value_1 >> ((i - 8) * 8)) & 0xff;
// instead of getting a new multi-byte random value
// for each key index.
switch (turn_random() % 3) {
case 0:
key[i] = (turn_random() % 10) + 48;
continue;
case 1:
key[i] = (turn_random() % 26) + 65;
continue;
default:
key[i] = (turn_random() % 26) + 97;
continue;
} }
}
FILE *fptr = fopen(filePath, "w"); FILE *fptr = fopen(filePath, "wb");
if (!fptr) { if (!fptr) {
return; return;
} }