master/coturn
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Improve MySQL connection error logging to include actual MySQL error message (#1679)

Browse Source 
Address #270

MySQL reconnectiong after priviledge drop and reporting missleading
error log.
"Cannot open MySQL DB connection: <%s>, runtime error\n"

Always include the mysql error message for additional context.
This commit is contained in:
Gustavo Garcia 2025-05-22 11:29:36 +02:00 committed by GitHub
parent c0b2c8d389
commit 8a71069517
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/apps/relay/dbdrivers/dbd_mysql.c
View File

@ -295,8 +295,8 @@ static MYSQL *get_mydb_connection(void) {
MYSQL *conn = mysql_real_connect(mydbconnection, co->host, co->user, co->password, co->dbname, co->port, NULL,
CLIENT_IGNORE_SIGPIPE);
if (!conn) {
TURN_LOG_FUNC(TURN_LOG_LEVEL_ERROR, "Cannot open MySQL DB connection: <%s>, runtime error\n",
pud->userdb_sanitized);
TURN_LOG_FUNC(TURN_LOG_LEVEL_ERROR, "Cannot open MySQL DB connection: <%s>, runtime error: %s\n",
pud->userdb_sanitized, mysql_error(mydbconnection));
mysql_close(mydbconnection);
mydbconnection = NULL;
} else if (mysql_select_db(mydbconnection, co->dbname)) {