From 9485c9567e98eb7d0c32766ea4eb26a2d83609f8 Mon Sep 17 00:00:00 2001
From: Subhra264 <chakrabortysubhradeep556@gmail.com>
Date: Thu, 23 Nov 2023 10:00:27 +0530
Subject: [PATCH] Fix: Return correct error code for `create_relay_connection`
 in case of `RESERVATION-TOKEN` failure (#1319)

Fixes #1266

According to RFC 5766, [section 6.2](https://www.rfc-editor.org/rfc/rfc5766#section-6.2) point no. 5, the turn server needs to reject the request with 508 (Insufficient Capacity) error code when the given RESERVATION-TOKEN is not valid.
---
 src/server/ns_turn_server.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/server/ns_turn_server.c b/src/server/ns_turn_server.c
index 3c0eb8d..f92f421 100644
--- a/src/server/ns_turn_server.c
+++ b/src/server/ns_turn_server.c
@@ -4241,7 +4241,7 @@ static int create_relay_connection(turn_turnserver *server, ts_ur_super_session
           ioa_socket_tobeclosed(s)) {
 
         IOA_CLOSE_SOCKET(s);
-        *err_code = 404;
+        *err_code = 508;
         *reason = (const uint8_t *)"Cannot find reserved socket";
         return -1;
       }