98d91a73cf
Marking variables as const when they won't be modified after initialization helps programmers trying to understand a codebase to manage the cognative load. This pull request uses a clang-tidy fixit (Hard to automate, since the code needs to be temporarily compiled as C++ for it to work) to try to mechanically apply the const keyword to code where the automated tool can determine that the variable won't be modified. I then follow this up with a manual improvement pass to turnutils_uclient, where I address const correctness of local variables, as well as do some adjustments to loops and scoping to help with reducing complexity. Co-authored-by: redraincatching <redraincatching@disroot.org> Co-authored-by: Pavel Punsky <eakraly@users.noreply.github.com>
139 lines
4.1 KiB
C
139 lines
4.1 KiB
C
/*
|
|
* SPDX-License-Identifier: BSD-3-Clause
|
|
*
|
|
* https://opensource.org/license/bsd-3-clause
|
|
*
|
|
* Copyright (C) 2011, 2012, 2013 Citrix Systems
|
|
* Copyright (C) 2014 Vivocha S.p.A.
|
|
*
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions
|
|
* are met:
|
|
* 1. Redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer.
|
|
* 2. Redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in the
|
|
* documentation and/or other materials provided with the distribution.
|
|
* 3. Neither the name of the project nor the names of its contributors
|
|
* may be used to endorse or promote products derived from this software
|
|
* without specific prior written permission.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE PROJECT AND CONTRIBUTORS ``AS IS'' AND
|
|
* ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
|
|
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
|
|
* ARE DISCLAIMED. IN NO EVENT SHALL THE PROJECT OR CONTRIBUTORS BE LIABLE
|
|
* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
|
|
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
|
|
* OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
|
|
* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
|
|
* LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
|
|
* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
|
|
* SUCH DAMAGE.
|
|
*/
|
|
|
|
#include "../mainrelay.h"
|
|
|
|
#include "apputils.h"
|
|
|
|
#include "dbd_mongo.h"
|
|
#include "dbd_mysql.h"
|
|
#include "dbd_pgsql.h"
|
|
#include "dbd_redis.h"
|
|
#include "dbd_sqlite.h"
|
|
#include "dbdriver.h"
|
|
|
|
static void make_connection_key(void) { (void)pthread_key_create(&connection_key, NULL); }
|
|
|
|
pthread_key_t connection_key;
|
|
pthread_once_t connection_key_once = PTHREAD_ONCE_INIT;
|
|
|
|
void convert_string_key_to_binary(const char *keysource, hmackey_t key, size_t sz) {
|
|
char is[3];
|
|
size_t i;
|
|
unsigned int v;
|
|
is[2] = 0;
|
|
for (i = 0; i < sz; i++) {
|
|
is[0] = keysource[i * 2];
|
|
is[1] = keysource[i * 2 + 1];
|
|
sscanf(is, "%02x", &v);
|
|
key[i] = (unsigned char)v;
|
|
}
|
|
}
|
|
|
|
persistent_users_db_t *get_persistent_users_db(void) { return &(turn_params.default_users_db.persistent_users_db); }
|
|
|
|
const turn_dbdriver_t *get_dbdriver(void) {
|
|
if (turn_params.default_users_db.userdb_type == TURN_USERDB_TYPE_UNKNOWN) {
|
|
return NULL;
|
|
}
|
|
|
|
(void)pthread_once(&connection_key_once, make_connection_key);
|
|
|
|
static const turn_dbdriver_t *_driver = NULL;
|
|
|
|
if (_driver == NULL) {
|
|
|
|
switch (turn_params.default_users_db.userdb_type) {
|
|
#if !defined(TURN_NO_SQLITE)
|
|
case TURN_USERDB_TYPE_SQLITE:
|
|
_driver = get_sqlite_dbdriver();
|
|
break;
|
|
#endif
|
|
#if !defined(TURN_NO_PQ)
|
|
case TURN_USERDB_TYPE_PQ:
|
|
_driver = get_pgsql_dbdriver();
|
|
break;
|
|
#endif
|
|
#if !defined(TURN_NO_MYSQL)
|
|
case TURN_USERDB_TYPE_MYSQL:
|
|
_driver = get_mysql_dbdriver();
|
|
break;
|
|
#endif
|
|
#if !defined(TURN_NO_MONGO)
|
|
case TURN_USERDB_TYPE_MONGO:
|
|
_driver = get_mongo_dbdriver();
|
|
break;
|
|
#endif
|
|
case TURN_USERDB_TYPE_REDIS:
|
|
_driver = get_redis_dbdriver();
|
|
break;
|
|
default:
|
|
break;
|
|
}
|
|
}
|
|
return _driver;
|
|
}
|
|
|
|
char *sanitize_userdb_string(char *udb) {
|
|
char *ret = NULL;
|
|
char *pstart;
|
|
char *pend;
|
|
|
|
/* host=localhost dbname=coturn user=turn password=turn connect_timeout=30 */
|
|
ret = strdup(udb);
|
|
pstart = strstr(ret, "password=");
|
|
if (pstart != NULL) {
|
|
pstart += strlen("password=");
|
|
pend = strstr(pstart, " ");
|
|
size_t plen = pend - pstart;
|
|
if (pend == NULL) {
|
|
plen = strlen(pstart);
|
|
}
|
|
memset(pstart, '*', plen);
|
|
} else {
|
|
/* postgresql://username:password@/databasename */
|
|
pstart = strstr(ret, "postgresql://");
|
|
if (pstart != NULL) {
|
|
pstart += strlen("postgresql://");
|
|
pend = strstr(pstart, "@");
|
|
if (pend != NULL) {
|
|
const size_t plen = pend - pstart;
|
|
memset(pstart, '*', plen);
|
|
}
|
|
}
|
|
}
|
|
return ret;
|
|
}
|