From 61bc443bdf987c7cd3a6b81d1368cc156257fb53 Mon Sep 17 00:00:00 2001 From: Adam Brown Date: Mon, 31 Jan 2022 14:17:35 +0000 Subject: [PATCH 1/5] enabling the use case feature by default --- vector/src/main/java/im/vector/app/features/VectorFeatures.kt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vector/src/main/java/im/vector/app/features/VectorFeatures.kt b/vector/src/main/java/im/vector/app/features/VectorFeatures.kt index 03e9954b2c..fe8d58fb51 100644 --- a/vector/src/main/java/im/vector/app/features/VectorFeatures.kt +++ b/vector/src/main/java/im/vector/app/features/VectorFeatures.kt @@ -36,5 +36,5 @@ class DefaultVectorFeatures : VectorFeatures { override fun onboardingVariant(): VectorFeatures.OnboardingVariant = BuildConfig.ONBOARDING_VARIANT override fun isOnboardingAlreadyHaveAccountSplashEnabled() = true override fun isOnboardingSplashCarouselEnabled() = true - override fun isOnboardingUseCaseEnabled() = false + override fun isOnboardingUseCaseEnabled() = true } From 5ed1f34df3e486c88307fb1eee02ac0a02e73726 Mon Sep 17 00:00:00 2001 From: Adam Brown Date: Mon, 31 Jan 2022 14:19:22 +0000 Subject: [PATCH 2/5] promoting use case strings for translation --- vector/src/main/res/values/donottranslate.xml | 11 ----------- vector/src/main/res/values/strings.xml | 11 +++++++++++ 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/vector/src/main/res/values/donottranslate.xml b/vector/src/main/res/values/donottranslate.xml index af2319883c..411236a62f 100755 --- a/vector/src/main/res/values/donottranslate.xml +++ b/vector/src/main/res/values/donottranslate.xml @@ -16,15 +16,4 @@ Cut the slack from teams. - - - Who will you chat to the most? - We\'ll help you get connected. - Friends and family - Teams - Communities - Not sure yet? %s - You can skip this question - Looking to join an existing server? - Connect to server diff --git a/vector/src/main/res/values/strings.xml b/vector/src/main/res/values/strings.xml index 67f3a08e5f..15a2d3db39 100644 --- a/vector/src/main/res/values/strings.xml +++ b/vector/src/main/res/values/strings.xml @@ -2556,6 +2556,17 @@ ${app_name} is also great for the workplace. It’s trusted by the world’s most secure organisations. + Who will you chat to the most? + We\'ll help you get connected. + Friends and family + Teams + Communities + + Not sure yet? %s + You can skip this question + Looking to join an existing server? + Connect to server + It\'s your conversation. Own it. Chat with people directly or in groups Keep conversations private with encryption From bac60677d58cd989429f3b0dc4e0d27e538ca345 Mon Sep 17 00:00:00 2001 From: Adam Brown Date: Tue, 1 Feb 2022 14:07:29 +0000 Subject: [PATCH 3/5] applying design feedback --- .../main/res/layout/fragment_ftue_auth_use_case.xml | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/vector/src/main/res/layout/fragment_ftue_auth_use_case.xml b/vector/src/main/res/layout/fragment_ftue_auth_use_case.xml index 21a70ded6e..76f29aaab9 100644 --- a/vector/src/main/res/layout/fragment_ftue_auth_use_case.xml +++ b/vector/src/main/res/layout/fragment_ftue_auth_use_case.xml @@ -79,7 +79,7 @@ Date: Tue, 1 Feb 2022 17:57:07 +0000 Subject: [PATCH 4/5] updating copy split to match designs --- vector/src/main/res/values/strings.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/vector/src/main/res/values/strings.xml b/vector/src/main/res/values/strings.xml index 15a2d3db39..d34a575037 100644 --- a/vector/src/main/res/values/strings.xml +++ b/vector/src/main/res/values/strings.xml @@ -2562,8 +2562,8 @@ Teams Communities - Not sure yet? %s - You can skip this question + Not sure yet? You can %s + skip this question Looking to join an existing server? Connect to server From 63a937c09632f87a27b10e53cca05617537f50e9 Mon Sep 17 00:00:00 2001 From: Adam Brown Date: Tue, 1 Feb 2022 13:31:21 +0000 Subject: [PATCH 5/5] taking the use case screen into account when accessing the sign up flows in the sanity tests --- .../java/im/vector/app/ui/robot/OnboardingRobot.kt | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/vector/src/androidTest/java/im/vector/app/ui/robot/OnboardingRobot.kt b/vector/src/androidTest/java/im/vector/app/ui/robot/OnboardingRobot.kt index 47bf31355c..b3bb5172e8 100644 --- a/vector/src/androidTest/java/im/vector/app/ui/robot/OnboardingRobot.kt +++ b/vector/src/androidTest/java/im/vector/app/ui/robot/OnboardingRobot.kt @@ -40,8 +40,11 @@ class OnboardingRobot { private fun crawlGetStarted() { clickOn(R.id.loginSplashSubmit) + assertDisplayed(R.id.useCaseHeaderTitle, R.string.ftue_auth_use_case_title) + clickOn(R.id.useCaseOptionOne) OnboardingServersRobot().crawlSignUp() pressBack() + pressBack() } private fun crawlAlreadyHaveAccount() { @@ -66,6 +69,7 @@ class OnboardingRobot { assertDisplayed(R.id.loginSplashSubmit, R.string.login_splash_create_account) if (createAccount) { clickOn(R.id.loginSplashSubmit) + clickOn(R.id.useCaseOptionOne) } else { clickOn(R.id.loginSplashAlreadyHaveAccount) }