From dd83c16e4699d7262e77ce5e2f4132accb58300e Mon Sep 17 00:00:00 2001
From: SpiritCroc <dev@spiritcroc.de>
Date: Sat, 17 Dec 2022 15:18:03 +0100
Subject: [PATCH] Disable useless thread fallback to reply fallback calculation

Don't ask me why Element did that much effort for those, instead of just
doing rich replies...

Change-Id: I90146a34b7a29896f550fcde50f821af629d7edb
---
 .../handler/room/ThreadsAwarenessHandler.kt    | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/session/sync/handler/room/ThreadsAwarenessHandler.kt b/matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/session/sync/handler/room/ThreadsAwarenessHandler.kt
index 70553359ff..d1818646d9 100644
--- a/matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/session/sync/handler/room/ThreadsAwarenessHandler.kt
+++ b/matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/session/sync/handler/room/ThreadsAwarenessHandler.kt
@@ -79,6 +79,8 @@ internal class ThreadsAwarenessHandler @Inject constructor(
      * @param syncResponse the sync response
      */
     suspend fun fetchRootThreadEventsIfNeeded(syncResponse: SyncResponse) {
+        // SC: this makes only sense for fallback replies
+        if (true) return
         val handlingStrategy = syncResponse.rooms?.join?.let {
             RoomSyncHandler.HandlingStrategy.JOINED(it)
         }
@@ -98,6 +100,8 @@ internal class ThreadsAwarenessHandler @Inject constructor(
      * @param eventList a list with the events to examine
      */
     suspend fun fetchRootThreadEventsIfNeeded(eventList: List<Event>) {
+        // SC: this makes only sense for fallback replies
+        if (true) return
         if (eventList.isNullOrEmpty()) return
 
         val threadsToFetch = emptyMap<String, String>().toMutableMap()
@@ -120,6 +124,8 @@ internal class ThreadsAwarenessHandler @Inject constructor(
      * Fetch multiple unique events using the fetchEvent function.
      */
     private suspend fun fetchThreadsEvents(threadsToFetch: Map<String, String>) {
+        // SC: this makes only sense for fallback replies
+        if (true) return
         val eventEntityList = threadsToFetch.mapNotNull { (eventId, roomId) ->
             fetchEvent(eventId, roomId)?.let {
                 it.toEntity(roomId, SendState.SYNCED, it.ageLocalTs ?: clock.epochMillis())
@@ -164,6 +170,8 @@ internal class ThreadsAwarenessHandler @Inject constructor(
             event: Event?,
             eventEntity: EventEntity? = null
     ): String? {
+        // SC: this makes only sense for fallback replies
+        if (true) return null
         event ?: return null
         roomId ?: return null
         if (lightweightSettingsStorage.areThreadMessagesEnabled() && !isReplyEvent(event)) return null
@@ -222,6 +230,8 @@ internal class ThreadsAwarenessHandler @Inject constructor(
             eventEntity: EventEntity?,
             event: Event
     ): String? {
+        // SC: this makes only sense for fallback replies
+        if (true) return null
         if (!isThreadEvent(event) && cacheEventRootId.contains(eventEntity?.eventId)) {
             eventEntity?.let {
                 val eventBody = event.getDecryptedTextSummary() ?: return null
@@ -251,6 +261,8 @@ internal class ThreadsAwarenessHandler @Inject constructor(
             isFromCache: Boolean,
             threadRelation: RelationDefaultContent?
     ): String? {
+        // SC: this makes only sense for fallback replies
+        if (true) return null
         event.eventId ?: return null
         val rootThreadEventId = if (isFromCache) event.eventId else event.getRootThreadEventId() ?: return null
         eventThatRelatesTo(realm, event.eventId, rootThreadEventId)?.forEach { eventEntityFound ->
@@ -281,6 +293,8 @@ internal class ThreadsAwarenessHandler @Inject constructor(
             eventPayload: MutableMap<String, Any>,
             messageTextContent: Content
     ): String? {
+        // SC: this makes only sense for fallback replies
+        if (true) return null
         eventPayload["content"] = messageTextContent
 
         if (event.isEncrypted()) {
@@ -317,6 +331,8 @@ internal class ThreadsAwarenessHandler @Inject constructor(
             eventToInjectBody: String,
             threadRelation: RelationDefaultContent?
     ): Content? {
+        // SC: this makes only sense for fallback replies
+        if (true) return null
         val eventToInjectId = eventToInject.eventId ?: return null
         val eventIdToInjectSenderId = eventToInject.senderId.orEmpty()
         val permalink = permalinkFactory.createPermalink(roomId, eventToInjectId, false)
@@ -348,6 +364,8 @@ internal class ThreadsAwarenessHandler @Inject constructor(
             eventPayload: MutableMap<String, Any>,
             threadRelation: RelationDefaultContent?
     ): String? {
+        // SC: this makes only sense for fallback replies
+        if (true) return null
         val replyFormatted = LocalEchoEventFactory.QUOTE_PATTERN.format(
                 "In reply to a thread",
                 eventBody