master/synapse
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Reduce database usage in Sliding Sync by not querying for background update completion after the update is known to be complete. (#18718)

Browse Source 
Signed-off-by: Olivier 'reivilibre <oliverw@matrix.org>
Co-authored-by: Eric Eastwood <erice@element.io>
This commit is contained in:
reivilibre 2025-07-24 15:58:39 +01:00 committed by GitHub
parent 1dd5f68251
commit 458e6410e8
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 14 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
changelog.d/18718.misc Normal file
View File

@ -0,0 +1 @@
Reduce database usage in Sliding Sync by not querying for background update completion after the update is known to be complete.

14
synapse/storage/databases/main/events_worker.py
View File

@ -367,6 +367,12 @@ class EventsWorkerStore(SQLBaseStore):
replaces_index="event_txn_id_device_id_txn_id",
)
self._has_finished_sliding_sync_background_jobs = False
"""
Flag to track when the sliding sync background jobs have
finished (so we don't have to keep querying it every time)
"""
def get_un_partial_stated_events_token(self, instance_name: str) -> int:
return (
self._un_partial_stated_events_stream_id_gen.get_current_token_for_writer(
@ -2658,13 +2664,19 @@ class EventsWorkerStore(SQLBaseStore):
async def have_finished_sliding_sync_background_jobs(self) -> bool:
"""Return if it's safe to use the sliding sync membership tables."""
return await self.db_pool.updates.have_completed_background_updates(
if self._has_finished_sliding_sync_background_jobs:
# as an optimisation, once the job finishes, don't issue another
# database transaction to check it, since it won't 'un-finish'
return True
self._has_finished_sliding_sync_background_jobs = await self.db_pool.updates.have_completed_background_updates(
(
_BackgroundUpdates.SLIDING_SYNC_PREFILL_JOINED_ROOMS_TO_RECALCULATE_TABLE_BG_UPDATE,
_BackgroundUpdates.SLIDING_SYNC_JOINED_ROOMS_BG_UPDATE,
_BackgroundUpdates.SLIDING_SYNC_MEMBERSHIP_SNAPSHOTS_BG_UPDATE,
)
)
return self._has_finished_sliding_sync_background_jobs
async def get_sent_invite_count_by_user(self, user_id: str, from_ts: int) -> int:
"""