master/synapse
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Revert "Move start_doing_background_updates() to SynapseHomeServer.start_background_tasks() (#19036)" (#19059)

Browse Source 
### Why

See
https://github.com/element-hq/synapse/pull/19036#discussion_r2427070612

Revert while I figure out the tests in
https://github.com/element-hq/synapse/pull/19057
This commit is contained in:
Eric Eastwood 2025-10-20 10:55:41 -05:00 committed by GitHub
parent 67f22a200d
commit eac862629f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
changelog.d/19036.misc
View File

@ -1 +0,0 @@
Move `start_doing_background_updates()` to `SynapseHomeServer.start_background_tasks()`.

8
synapse/app/homeserver.py
View File

@ -317,11 +317,6 @@ class SynapseHomeServer(HomeServer):
# during parsing
logger.warning("Unrecognized listener type: %s", listener.type)
def start_background_tasks(self) -> None:
super().start_background_tasks()
self.get_datastores().main.db_pool.updates.start_doing_background_updates()
def load_or_generate_config(argv_options: List[str]) -> HomeServerConfig:
"""
@ -435,6 +430,9 @@ def setup(
await _base.start(hs, freeze)
# TODO: Feels like this should be moved somewhere else.
hs.get_datastores().main.db_pool.updates.start_doing_background_updates()
# Register a callback to be invoked once the reactor is running
register_start(hs, _start_when_reactor_running)